Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DPI awareness support to VS2010+ projects #949

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

samsinsane
Copy link
Member

Resolves #783

Copy link
Contributor

@tvandijck tvandijck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this flag accomplish in visual studio?
and please add documentation...

@samsinsane
Copy link
Member Author

@tvandijck Not overly sure to be honest, it was a feature request. However, it looks like it enables various functions to respond differently based on the setting. (I skimmed this page, so I could be incredibly wrong)

@samsinsane
Copy link
Member Author

Added documentation, is the availability right? Are we drilling down into the alpha releases? I feel like I saw that the other day, but I'm not sure what it was on.

@tvandijck tvandijck merged commit e768d4a into premake:master Nov 28, 2017
@tvandijck
Copy link
Contributor

Availability should be alright...
In my opinion our next release should just be 5.0, or preferably 5.1 (see below), we've been in alpha for 3 years now, things seem pretty stable overall.

All the ideas @starkos has for the query system seem a rather large refactor and deviation from what we have currently that I'd almost argue that that is a 5.5 or even a 6.0. We are internally experimenting with that too btw, based on his ideas and test branches.

The other thing I really think we should be doing is automate the release number.
We use this modification:

which basically just takes the tag number from git, and embeds that into the source code. I proposed it once as a PR, but I think at the time there was some argument about the dependency on git, which I feel is somewhat moot since we're on github, and it's just the embed script for automation, we can easily extent it to support other source control systems, or use a command line argument to use the git system, and default to the current behavior..

We could start at 5.0.0, although it'll screw us up a little bit, as we by now are at 5.0.41, but we'll figure that part out here then. We could also just start at 5.1.0, which would help us out.

@pdoane
Copy link

pdoane commented Nov 28, 2017

The Windows 10 Creators Update made additional changes to DPI awareness. There are now 4 values that are interesting:

  • Unaware
  • System Aware
  • Per Monitor Aware V1
  • Per Monitor Aware V2

For PerMonitorV2, the manifest should generate:

<dpiAware>True/PM</dpiAware>
<dpiAwareness>PerMonitorV2, PerMonitor</dpiAwareness>

I don't think PerMonitorV2 has been reflected into .vcxproj yet.

It might be a good idea to change the enumeration names as "High" isn't really clear as to whether it should map to V1 or V2 rules.

More details here: https://blogs.windows.com/buildingapps/2017/04/04/high-dpi-scaling-improvements-desktop-applications-windows-10-creators-update/

@samsinsane samsinsane deleted the ssurtees/DPIAwareness branch February 5, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants